-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
calendar: update for py312 #10216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calendar: update for py312 #10216
Conversation
This comment has been minimized.
This comment has been minimized.
|
Not sure what pyright wants here, bug? |
Oh, no idea what's going on there. We're a few pyright releases behind in CI; we could try updating to the latest and see if it still reproduces? |
JelleZijlstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the enum issue is mysterious to me too.
I would suggest it's an import cycle issue, but nothing in the stdlib relies on calendar.
|
Yeah, seems like the failures persist with the latest pyright |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
cc @erictraut any idea what's going wrong here? |
|
This is caused by a circular dependency involving the The This circularity can be resolved if analysis is done in precisely the right order. Since pyright is a lazy (just-in-time) type analyzer, the standard ordering can easily change. I suspect that the change in this PR perturbed things just enough to change the evaluation ordering. I have logic in place that's designed to detect circularities like this and force them to resolve in a satisfactory order, but the logic is complex, and it appears that it's not handling this case. I'll investigate it further. I've filed this bug in the pyright issue tracker. |
|
This will be fixed in the next pyright release (1.1.312). |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
No description provided.