This repository was archived by the owner on Jul 5, 2023. It is now read-only.
Check NEW_TYPE_COMMENT calls for failure #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly cribbed from python/cpython#11645, though it also adds a new error check to new_type_comment itself.
gvanrossum
approved these changes
Feb 6, 2019
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Thanks! I'll submit a PR to add the extra error check to new_type_comment() upstream.
gvanrossum
added a commit
to python/cpython
that referenced
this pull request
Feb 6, 2019
If PyUnicode_DecodeUTF8() returns NULL, PyArena_AddPyObject() would crash. Found by @msullivan for python/typed_ast#93.
gvanrossum
added a commit
to python/cpython
that referenced
this pull request
Feb 11, 2019
If PyUnicode_DecodeUTF8() returns NULL, PyArena_AddPyObject() would crash. Found by @msullivan for python/typed_ast#93.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly cribbed from python/cpython#11645,
though it also adds a new error check to new_type_comment itself.