Skip to content

Pospell + rapide - #991

Merged
JulienPalard merged 10 commits into
python:3.8from
awecx:pospell
Dec 10, 2019
Merged

JulienPalard merged 10 commits into
python:3.8from
awecx:pospell

Conversation

@awecx

@awecx awecx commented Nov 16, 2019

Copy link
Copy Markdown
Contributor

Closes #974

@awecx awecx mentioned this pull request Nov 16, 2019
@awecx

awecx commented Nov 16, 2019

Copy link
Copy Markdown
Contributor Author

Discussion complète dans #974.

Seluj78
Seluj78 previously approved these changes Nov 16, 2019

@Seluj78 Seluj78 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pas testé mais les commandes me semble bien 👌

@Seluj78 Seluj78 added the NEED REVIEWER This PR needs a reviewer :) label Nov 17, 2019
@Seluj78
Seluj78 requested a review from JulienPalard November 17, 2019 21:25
@awecx

awecx commented Dec 4, 2019

Copy link
Copy Markdown
Contributor Author

@JulienPalard qu'en penses-tu ?

@vpoulailleau vpoulailleau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deux questions sans conviction 😉

Comment thread Makefile Resolved
Comment thread Makefile Resolved

@JulienPalard JulienPalard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour le ping, super idée !

Comment thread Makefile Resolved
Comment thread Makefile Resolved
Comment thread Makefile Resolved
Comment thread Makefile Resolved

@vpoulailleau vpoulailleau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cf mon commentaire précédent.

Comment thread Makefile Resolved
@JulienPalard

Copy link
Copy Markdown
Member

@awecx sry je t'ai fait conflict. Mais j'assume, j'ai résolu le conflit. J'espère ne pas avoir introduit un sushi (je l'ai fait via l'interface de github)

@awecx

awecx commented Dec 10, 2019

Copy link
Copy Markdown
Contributor Author

@awecx sry je t'ai fait conflict. Mais j'assume, j'ai résolu le conflit. J'espère ne pas avoir introduit un sushi (je l'ai fait via l'interface de github)

Ça m'a l'air OK.

@JulienPalard
JulienPalard merged commit 79bcbf1 into python:3.8 Dec 10, 2019
@awecx
awecx deleted the pospell branch May 19, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NEED REVIEWER This PR needs a reviewer :)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pospell est trop lent.

4 participants