Merged
Conversation
Member
|
@deronnax Je viens de release pospell 0.3.4 qui fix le fait qu'il coupait le nom de Marc-André en deux. Tu peux whitelister Marc-André dans dict. |
Member
|
Pour ton problème de ss j'ai pas de solution élégante, on se rabbat sur l'italique si tu n'en trouve pas non plus ? |
christopheNan
suggested changes
Jun 3, 2019
Contributor
christopheNan
left a comment
christopheNan
left a comment
There was a problem hiding this comment.
Merci pour cette très bonne contribution.
JulienPalard
added
awaiting changes
and removed
NEED REVIEWER
Collaborator
Author
|
J'ai intégré tous les changements de @christopheNan . N'il y a-t-il pas dans Github un moyen de marquer la review, les changes requested, comme completés, résolus ? |
Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
Member
|
LGTM ! Merci @deronnax je merge ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Petite baisse d'inspiration sur la fin, vos observations sont les bienvenues.
Pospell s'étouffe sur "ss" et "Marc-", quelle est la solution élégante à ça ?