Skip to content

Translated using/unix.po#429

Merged
JulienPalard merged 13 commits into
python:3.7from
Seluj78:using-unix
Dec 13, 2018
Merged

Translated using/unix.po#429
JulienPalard merged 13 commits into
python:3.7from
Seluj78:using-unix

Conversation

@Seluj78

@Seluj78 Seluj78 commented Nov 14, 2018

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated

@JulienPalard JulienPalard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Énormément de conversations de @awecx étaient marquées commes résolues mais ne l'étaient pas, fait attention à ça, ce n'est pas la première fois que ça t'arrive.

Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
JulienPalard and others added 2 commits November 29, 2018 16:14
Co-Authored-By: Seluj78 <jlasne@student.42.fr>
@Seluj78

Seluj78 commented Nov 29, 2018

Copy link
Copy Markdown
Collaborator Author

@JulienPalard les suggestions qui sont fermées auto de @awecx sont peut etre fermées auto par GH quand je push qq chose qui modifie la ligne dont le commentaire fait référence

awecx and others added 2 commits November 29, 2018 16:16
Co-Authored-By: Seluj78 <jlasne@student.42.fr>
Co-Authored-By: Seluj78 <jlasne@student.42.fr>
@JulienPalard

Copy link
Copy Markdown
Member

@JulienPalard les suggestions qui sont fermées auto de @awecx sont peut etre fermées auto par GH quand je push qq chose qui modifie la ligne dont le commentaire fait référence

Oui, probablement. Mais ça t'arrive régulièrement sur tes PR donc je pense qu'il faut que tu y prête attention.

Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
awecx and others added 3 commits November 30, 2018 14:08
Co-Authored-By: Seluj78 <jlasne@student.42.fr>
Co-Authored-By: Seluj78 <jlasne@student.42.fr>
@Seluj78

Seluj78 commented Nov 30, 2018

Copy link
Copy Markdown
Collaborator Author

Should be good for another pass on review :)

Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Comment thread using/unix.po Outdated
Co-Authored-By: Seluj78 <jlasne@student.42.fr>
@Seluj78

Seluj78 commented Dec 11, 2018

Copy link
Copy Markdown
Collaborator Author

Comments from @JulienPalard were fixed.

@JulienPalard JulienPalard merged commit f79fbfa into python:3.7 Dec 13, 2018
@JulienPalard

Copy link
Copy Markdown
Member

👍

@Seluj78 Seluj78 deleted the using-unix branch December 14, 2018 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants