Completed distutils/apiref : Go ? #378
Merged
Merged
Conversation
Krilivye
changed the title
christopheNan
suggested changes
Oct 11, 2018
christopheNan
suggested changes
Oct 16, 2018
christopheNan
suggested changes
Oct 16, 2018
Krilivye
changed the title
christopheNan
suggested changes
Oct 22, 2018
christopheNan
left a comment
christopheNan
left a comment
Contributor
There was a problem hiding this comment.
Très grosse contribution de grande qualité !
Beaucoup de remarques, mais pratiquement que de la forme.
Notamment, le futur est pratiquement toujours inutile. Le français préfère le présent dans la documentation technique.
Les définitions commencent par le verbe au présent sans sujet. Tu as mis parfois des infinitifs, ce qui casse la cohérence avec le reste de la documentation.
Un grand merci pour ce très gros morceau.
Contributor
Author
|
Merci pour le retour! Je prévois de faire la passe de correction/cohérence ce weekend 27-28 ;) |
Krilivye
changed the title
Contributor
Author
|
Une dernière revue pour la route ? ;) |
christopheNan
approved these changes
Oct 29, 2018
Krilivye
changed the title
Member
|
Wow grosse PR, et bump à 33.7% d'un coup ! GG ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
je pull-request pour me pousser à continuer ;)
"Bug" sur la doc en anglais:
/distutils/apiref.html#distutils.ccompiler.gen_preprocess_options -- pas très lisible à mon sens.
une référence utile : https://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html
Reste a faire une passe de cohérence + relecture finale indépendante ;)
J'ai un gros doute sur "line-at-a-time lookahead" :2652