Skip to content

Avoid having this sha1 at two different places. #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christopheNan merged 1 commit into from
Sep 22, 2021
Merged

Avoid having this sha1 at two different places. #1688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ jobs:
run: |
mkdir -p ~/locales/fr/LC_MESSAGES/
cp -uv --parents *.po */*.po ~/locales/fr/LC_MESSAGES/
git -C ~/cpython checkout 895591c1f0bdec5ad357fe6a5fd0875990061357
git -C ~/cpython checkout $(grep ^CPYTHON_CURRENT_COMMIT Makefile| cut -d= -f2)
Copy link
Copy Markdown
Collaborator

@jeanas jeanas Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sinon, peut-être pourrait-on ajouter une cible dans le Makefile pour synchroniser les deux sans effort ?

Copy link
Copy Markdown
Contributor

@christopheNan christopheNan Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposition idiote : ne pourrait-on pas avoir un fichier CPYTHON_CURRENT_COMMIT à la racine dont le contenu est le hash du commit ?

Copy link
Copy Markdown
Member Author

@JulienPalard JulienPalard Sep 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je n'aime pas avoir trop de fichiers à la racine :D

Copy link
Copy Markdown
Member Author

@JulienPalard JulienPalard Sep 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sinon, peut-être pourrait-on ajouter une cible dans le Makefile pour synchroniser les deux sans effort ?

Qu'on va oublier aussi, je préfère n'avoir qu'une source de vérité.

- name: Prepare venv
run: |
# If the venv exists but is broken, drop it (happens on Python upgrades):
Expand Down