Skip to content

Readme contributing typos + code blocks changes#1039

Merged
deronnax merged 8 commits into
python:3.8from
Seluj78:readme-contributing-typos
May 2, 2020
Merged

Readme contributing typos + code blocks changes#1039
deronnax merged 8 commits into
python:3.8from
Seluj78:readme-contributing-typos

Conversation

@Seluj78

@Seluj78 Seluj78 commented Dec 5, 2019

Copy link
Copy Markdown
Collaborator

Closes #1032

@Seluj78 Seluj78 added NEED REVIEWER This PR needs a reviewer :) meta labels Dec 5, 2019
@Seluj78 Seluj78 self-assigned this Dec 5, 2019
Comment thread CONTRIBUTING.rst
Comment thread CONTRIBUTING.rst Outdated
@vpoulailleau

Copy link
Copy Markdown
Contributor

J'ai cliqué trop vite, mais je voulais dire qu'à part ça, tout me semble bon…

@deronnax

deronnax commented Dec 5, 2019

Copy link
Copy Markdown
Collaborator

Je comprends pas, le titre de la PR parle de typos, mais en fait c'est les commentaires du bloc de code qui deviennent du texte ?

@JulienPalard

Copy link
Copy Markdown
Member

Je comprends pas, le titre de la PR parle de typos, mais en fait c'est les commentaires du bloc de code qui deviennent du texte ?

Ouai.

Comment thread CONTRIBUTING.rst Outdated
Comment thread CONTRIBUTING.rst
Comment thread CONTRIBUTING.rst
@Seluj78

Seluj78 commented Dec 7, 2019

Copy link
Copy Markdown
Collaborator Author

@JulienPalard @deronnax En fait le titre est pas complet mais oui j'ai fix 1 typo et j'ai changé les code blocks

@Seluj78 Seluj78 changed the title Readme contributing typos Readme contributing typos + code blocks changes Dec 7, 2019
@Seluj78 Seluj78 removed the NEED REVIEWER This PR needs a reviewer :) label Dec 13, 2019
Comment thread CONTRIBUTING.rst

@christopheNan christopheNan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je préfère le présent.

Comment thread CONTRIBUTING.rst Outdated
Comment thread CONTRIBUTING.rst Outdated
Comment thread CONTRIBUTING.rst Outdated
Comment thread CONTRIBUTING.rst Outdated
Comment thread CONTRIBUTING.rst Outdated
Comment thread CONTRIBUTING.rst Outdated
Co-authored-by: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
@deronnax deronnax merged commit 939285b into python:3.8 May 2, 2020
@deronnax

deronnax commented May 2, 2020

Copy link
Copy Markdown
Collaborator

ENFIN !

@Seluj78 Seluj78 deleted the readme-contributing-typos branch February 15, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Découpez le nouveau CONTRIBUTING en plus petits codeblocks

6 participants