Skip to content

Conversation

@Seluj78
Copy link
Collaborator

@Seluj78 Seluj78 commented Nov 18, 2019

No description provided.

@Seluj78 Seluj78 added the NEED REVIEWER This PR needs a reviewer :) label Nov 18, 2019
@Seluj78 Seluj78 self-assigned this Nov 18, 2019
Copy link
Contributor

@vpoulailleau vpoulailleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est padpo !

Co-Authored-By: Vincent Poulailleau <vpoulailleau@gmail.com>
Copy link
Contributor

@christopheNan christopheNan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour cette contribution.
Quelques remarques.

library/re.po Outdated
"using triple-quoted string syntax"
msgstr ""
"Premièrement, voici l'entrée. Elle provient normalement d'un fichier, nous "
"Premièrement, voici l'entrée. Elle provient normalement d'un fichier, nous "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'enlèverais le «  premièrement » puisqu'il n'est pas suivi par «  deuxièmement ». Je le remplacerais par « D'abord ».

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"tout d'abord", ça te va ?

@deronnax
Copy link
Collaborator

Hello @christopheNan. Check ton Gmail ;)

Co-Authored-By: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
Copy link
Contributor

@vpoulailleau vpoulailleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Padpo adorerait un powrap 😉

@Seluj78 Seluj78 added awaiting changes and removed NEED REVIEWER This PR needs a reviewer :) labels Dec 13, 2019
@deronnax deronnax requested a review from christopheNan May 4, 2020 20:11
Co-authored-by: Christophe Nanteuil <35002064+christopheNan@users.noreply.github.com>
@deronnax deronnax requested a review from christopheNan May 8, 2020 19:47
@deronnax
Copy link
Collaborator

deronnax commented May 9, 2020

changements faits, @christopheNan

@deronnax
Copy link
Collaborator

@christopheNan ?

Copy link
Contributor

@christopheNan christopheNan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK pour moi.

@deronnax deronnax merged commit 13ddc4e into python:3.8 May 25, 2020
@Seluj78 Seluj78 deleted the fuzzies-re branch February 15, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants