Mejorando la guía de revisión#964
Merged
Merged
Conversation
Work in progress
cmaureir
reviewed
Oct 6, 2020
cmaureir
reviewed
Oct 6, 2020
cmaureir
left a comment
cmaureir
left a comment
Collaborator
There was a problem hiding this comment.
Para esconder el link en texto y que no quede el link completo como texto.
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
raulcd
reviewed
Oct 6, 2020
raulcd
left a comment
raulcd
left a comment
Collaborator
There was a problem hiding this comment.
Dos minor comments. Un typo que he encontrado y una sugerencia que no es necesaria.
Collaborator
|
No lo he dicho en la review pero me gusta mucho 👍 |
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
raulcd
approved these changes
Oct 6, 2020
Collaborator
|
no la mergeo, @silvinabt87 dale un vistazo y si te parece bien mergeas |
humitos
reviewed
Oct 6, 2020
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
cmaureir
reviewed
Oct 6, 2020
cmaureir
requested changes
Oct 6, 2020
cmaureir
left a comment
cmaureir
left a comment
Collaborator
There was a problem hiding this comment.
hay que mirar lo del link primero
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Collaborator
|
ahora si funciona el rendering del link :) |
Contributor
Author
|
me faltaria lo de las secciones ahora lo miro |
Contributor
Author
|
Creo que pinta mejora ahora :) https://python-docs-es--964.org.readthedocs.build/es/964/reviewers-guide.html si encontrais alguna cosa más que mejorar dejadmelo por aqui :) |
humitos
reviewed
Oct 6, 2020
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
clacri
commented
Oct 6, 2020
cmaureir
approved these changes
Oct 6, 2020
Collaborator
|
Quedó genial!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #953