Makefile fixes#713
Merged
Merged
Conversation
Travis is giving us a Python executable that it's already inside a virtualenv. So, using that executable to create another virtualenv does not work properly and all the packages are installed in the original virtualenv instead in the one created by the Makefile; which makes packages to not be found at `venv/bin/`. I'm using Travis `script` option to call the commands that we need just using the virtualenv they provide to us instead of calling `make build`.
humitos
force-pushed
the
makefile-fixes
branch
from
17b6726 to
9b8092e
Compare
- some mistyped roles - auditing event coming from Python souce code (.py) - mark a page (review guide) as orphan - missed quotes and wrong quotes
cmaureir
approved these changes
Aug 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sphinx-buildcommand has been failing for some time now. It seems that Travis-CI does not findsphinx-buildcommand but it does not report back that problem and just make it pass.I made some changes to report this problem and make the build to fail (added
&&to the command). Besides, I made Travis to not use our ownmake buildbecause Travis gives us a Python inside a virtualenv already, and our Makefile creates another venv using that virtualenv and makes things to behave wrong (packages are installed in the original virtualenv instead of the one we created)Because we haven't run
sphinx-buildin the last PRs, now that it's fixed and it's ran it shows some WARNINGs in thesphinx-buildcommand that we need to fix at some point.