traduccion faq/extending.po primer draft#645
Merged
Merged
Conversation
cmaureir
requested changes
Aug 6, 2020
Collaborator
|
encontré un par de cositas, a ver que te parecen :) |
Contributor
Author
|
@cmaureir ahi resolvi algunas otras tengo dudas lo podes revisar? gracias |
cmaureir
requested changes
Aug 10, 2020
cmaureir
left a comment
cmaureir
left a comment
Collaborator
There was a problem hiding this comment.
Vi que habían varios comentarios como resolve pero que que el contenido no está cambiado, quizás lo resolviste de manera local, pero dejé un par de comentarios en dos.
jcantilo
commented
Aug 10, 2020
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
cmaureir
reviewed
Aug 10, 2020
cmaureir
requested changes
Aug 10, 2020
cmaureir
left a comment
cmaureir
left a comment
Collaborator
There was a problem hiding this comment.
Encontré una cosita solamente haciendo el build local. Si le cambias el nombre al PR lo mergeamos luego de la sugerencia que encontre :)
Contributor
Author
|
@cmaureir ok pero no entiendo por que hay que cambiar el nombre al PR ni tampoco como se hace? |
cmaureir
approved these changes
Aug 10, 2020
Collaborator
|
Otro más que acabas @jcantilo 👏 🎉 Muchas gracias! |
Collaborator
|
Era que cambiaras ese título con el botón 'Edit', ya que dice "primer draft", pero no te preocupes. |
Co-authored-by: Cristián Maureira-Fredes <cmaureir@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #592