Traducido library/ast#484
Merged
Merged
Conversation
narvmtz
reviewed
Jul 25, 2020
Comment on lines
+144
to
+145
| "`end_col_offset` son las correspondientes compensaciones de bytes UTF-8 del " | ||
| "primer y último token que generó el nodo. El desplazamiento UTF-8 se " |
Contributor
There was a problem hiding this comment.
Suggested change
| "`end_col_offset` son las correspondientes compensaciones de bytes UTF-8 del " | |
| "primer y último token que generó el nodo. El desplazamiento UTF-8 se " | |
| "`end_col_offset` son las correspondientes compensaciones de bytes UTF-8 del " | |
| "primer y último token que generó el nodo. El desplazamiento UTF-8 se " |
Acá usas "compensaciones" y "desplazamiento" para "offsets", te parece si lo estandarizamos por alguno que encaje en ambas líneas?
| "If there are keyword arguments, they will set the attributes of the same " | ||
| "names to the given values." | ||
| msgstr "" | ||
| "Si hay argumentos de palabras clave, establecerán los atributos de los " |
Contributor
There was a problem hiding this comment.
Suggested change
| "Si hay argumentos de palabras clave, establecerán los atributos de los " | |
| "Si hay argumentos por palabras clave, establecerán los atributos de los " |
Collaborator
Author
There was a problem hiding this comment.
al final decidimos aceptar los dos :P "por" y "de"
narvmtz
suggested changes
Jul 25, 2020
narvmtz
left a comment
narvmtz
left a comment
Contributor
There was a problem hiding this comment.
Encontré una última cosita :)
Co-authored-by: narvmtz <51009725+narvmtz@users.noreply.github.com>
Contributor
|
Solo faltaría hacerle powrap y creo que con eso pasaría Travis :) |
Collaborator
Author
|
@narvmtz cuando le des approve mergeamos este :) |
narvmtz
approved these changes
Jul 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #469