Merged
Conversation
rtobar
reviewed
Oct 26, 2023
Collaborator
rtobar
left a comment
rtobar
left a comment
There was a problem hiding this comment.
Perdón por la tardía revisión, tenía algunos comentarios ya en el tintero y ahora por fin pude terminarlos
Contributor
Author
|
Saludos, he realizado cambios en base a las correcciones presentadas |
Collaborator
|
@Sublian Si te fijas los tests están fallando aún. Dales una mirada y ve que hace falta arreglar. Cuando estén pasando de nuevo podemos proseguir |
Contributor
Author
|
@rtobar listo he revisado y corregido en base a los datos del test. Creo que falta menos |
Contributor
Author
|
Lista la siguiente correción @rtobar |
rtobar
reviewed
Nov 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2625