Merged
Conversation
cacrespo
approved these changes
Oct 15, 2023
rtobar
reviewed
Oct 15, 2023
rtobar
requested changes
Oct 15, 2023
rtobar
approved these changes
Oct 15, 2023
Collaborator
|
Antes de mergear, podrías probar otra cosa? En vez de poner este fix, me gustaría saber qué pasa si pones todos los contenidos de Si eso funciona creo que sería una mejor solución a la propuesta., pero habría que ver que funcione en primer lugar 😛 |
Collaborator
Author
|
@rtobar funcionó!! 🙌 Y de una, me parece mejor solución. Gracias! Adjunto pruebas de que quedó funcionando, tanto con params como sin params.
|
erickisos
reviewed
Oct 16, 2023
rtobar
reviewed
Oct 16, 2023
Collaborator
rtobar
left a comment
There was a problem hiding this comment.
Un comentario pequeño, pero yo diría que se ve bien
Co-authored-by: rtobar <rtobarc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

kudos to Marcos Medrano who provide the code to make this fix 🎉