Traducido archivo library/calendar#2346
Merged
Merged
Conversation
rtobar
reviewed
Mar 10, 2023
rtobar
left a comment
rtobar
left a comment
Collaborator
There was a problem hiding this comment.
¡Muchas gracias @jmaxter por tu primera contribución! Se ve muy bien en general 👍, aunque como te diste cuenta había un problema con el archivo de TRANSLATORS. Te dejo un comentario al respecto para que lo soluciones, además de otros detallitoss que haría falta arreglar antes de poder hacer un merge.
¡Mucho ánimo! 💪
Contributor
Author
|
Enviado corrección de archivo TRANSLATORS y library/calendar. |
rtobar
reviewed
Mar 11, 2023
Contributor
Author
|
Finalizado library/calendar |
rtobar
approved these changes
Mar 11, 2023
rtobar
left a comment
rtobar
left a comment
Collaborator
There was a problem hiding this comment.
Estamos listos, todos los tests pasan ahora, así que vamos a mergear! 🎉
Un detalle que olvide mencionar: edité la descripción del PR para que al hacer el merge se cierre automáticamente el issue asociado.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1970