included eval#218
Merged
Merged
Conversation
… claudia_functions_38
humitos
approved these changes
May 10, 2020
humitos
left a comment
humitos
left a comment
Collaborator
There was a problem hiding this comment.
Genial! Te hice unas pequeñas sugerencias, que si las aceptas está listo para hacer merge 😄
marian-vignau
previously requested changes
May 10, 2020
marian-vignau
left a comment
marian-vignau
left a comment
Collaborator
There was a problem hiding this comment.
Muy buen trabajo!
Gracias!
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
Co-authored-by: marian-vignau <mavignau@gmail.com>
Co-authored-by: marian-vignau <mavignau@gmail.com>
Co-authored-by: marian-vignau <mavignau@gmail.com>
Contributor
Author
|
He aceptado vuestras sugerencias, gracias por la revisión. Lo de la configuración de las comillas me lo revisaré antes de hacer otro PR, gracias por el aviso. |
Collaborator
|
Gracias @clacri, sos una genia! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.