Skip to content

Translate using/windows.po #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cacrespo merged 8 commits into from
Feb 28, 2021
Merged

Translate using/windows.po #1191

cacrespo merged 8 commits into from
Feb 28, 2021

Conversation

@fzuccolo
Copy link
Contributor

@fzuccolo fzuccolo commented Jan 1, 2021 •
edited
Loading

Traducción completa del archivo using/windows.po (fix #302)

@fzuccolo fzuccolo marked this pull request as ready for review January 2, 2021 18:03
juansemarquez
juansemarquez suggested changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@juansemarquez juansemarquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muy buena traducción, muy clara en mi opinión.
Dejo algunas correcciones sugeridas.
Tené en cuenta que es el primer archivo que reviso, así que si surge alguna duda podés consultar con algún miembro del equipo más experimentado.
Gracias por tu trabajo.

using/windows.po Outdated
"compatibility and for compatibility with Unix, where the command ``python`` "
"typically refers to Python 2."
msgstr ""
"Tenga en cuenta que a diferencia del uso interactivo, un despojado \"python"
Copy link
Contributor

@juansemarquez juansemarquez Feb 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me suena rara la palabra "despojado"... Yo cambiaría la expresión completamente, algo así como "escribir solamente python", por ejemplo... No estoy seguro.

Copy link
Contributor Author

@fzuccolo fzuccolo Feb 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sí, suena rara, cambiado por el comando "python" (a secas) utilizará ... en f89f729. ¿Qué opinás?

@fzuccolo fzuccolo changed the title Translate using/windows.po (#302) Translate using/windows.po Feb 27, 2021
@fzuccolo
Copy link
Contributor Author

fzuccolo commented Feb 27, 2021

Muchas gracias @juansemarquez por la detallada revisión!
Concuerdo con todo lo señalado, ya apliqué las correcciones sugeridas.

juansemarquez
juansemarquez approved these changes Feb 28, 2021
View reviewed changes
Copy link
Contributor

@juansemarquez juansemarquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Gran trabajo @fzuccolo! ¡Felicitaciones!

@cacrespo cacrespo merged commit a2e96eb into python:3.8 Feb 28, 2021
@cacrespo
Copy link
Collaborator

cacrespo commented Feb 28, 2021

Felicitaciones @fzuccolo! Muy buen trabajo 🚀 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cacrespo cacrespo cacrespo approved these changes

+1 more reviewer

@juansemarquez juansemarquez juansemarquez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Translate using/windows.po

3 participants

@fzuccolo @cacrespo @juansemarquez