Skip to content

tornado: use WindowsSelectorEventLoopPolicy() with Python 3.8 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Jul 30, 2019
Merged

tornado: use WindowsSelectorEventLoopPolicy() with Python 3.8 #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pyperformance/benchmarks/bm_tornado_http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
data as a HTTP response's body.
"""

import sys
import socket

from six.moves import xrange
Expand Down Expand Up @@ -86,6 +87,16 @@ def run_client():


if __name__ == "__main__":
# 3.8 changed the default event loop to ProactorEventLoop which doesn't
# implement everything required by tornado and breaks this benchmark.
# Restore the old WindowsSelectorEventLoop default for now.
# https://bugs.python.org/issue37373
# https://github.com/python/pyperformance/issues/61
# https://github.com/tornadoweb/tornado/pull/2686
Comment thread
lazka marked this conversation as resolved.
Resolved
Comment thread
lazka marked this conversation as resolved.
Resolved
if sys.platform == 'win32' and sys.version_info[:2] == (3, 8):
import asyncio
asyncio.set_event_loop_policy(asyncio.WindowsSelectorEventLoopPolicy())

kw = {}
if pyperf.python_has_jit():
# PyPy needs to compute more warmup values to warmup its JIT
Expand Down