Skip to content

Fix --same-loops handling #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdboom merged 2 commits into from
Apr 9, 2025
Merged

Fix --same-loops handling #387

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7af1938
Fix --same-loops handling so it doesn't accumulate --loops arguments …
Yhg1s Apr 5, 2025
bee2900
Actually fix the bug now.
Yhg1s Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pyperformance/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def run_benchmarks(should_run, python, options):
run_count = str(len(to_run))
errors = []

pyperf_opts = get_pyperf_opts(options)
base_pyperf_opts = get_pyperf_opts(options)

import pyperf
for index, bench in enumerate(to_run):
Expand Down Expand Up @@ -159,7 +159,9 @@ def add_bench(dest_suite, obj):
return dest_suite

if name in loops:
pyperf_opts.append(f"--loops={loops[name]}")
pyperf_opts = [*base_pyperf_opts, f"--loops={loops[name]}"]
else:
pyperf_opts = base_pyperf_opts

bench_venv, bench_runid = benchmarks.get(bench)
if bench_venv is None:
Expand Down
Loading