Skip to content

Include cert files for asyncio_tcp_ssl benchmark #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kumaraditya303 merged 1 commit into from
May 9, 2023
Merged

Include cert files for asyncio_tcp_ssl benchmark #289

kumaraditya303 merged 1 commit into from
May 9, 2023

Conversation

@mdboom
Copy link
Contributor

@mdboom mdboom commented May 9, 2023

The asyncio_tcp_ssl benchmark currently fails when it's run on an installed pyperformance, because the cert files it depends on are not installed.

This updates the MANIFEST.in so they are installed.

2023-05-07T01:58:11.2528043Z   File "/home/benchmarking/actions-runner/_work/benchmarking/benchmarking/cpython/Lib/asyncio/runners.py", line 194, in run
2023-05-07T01:58:11.2528559Z     return runner.run(main)
2023-05-07T01:58:11.2528859Z            ^^^^^^^^^^^^^^^^
2023-05-07T01:58:11.2529594Z   File "/home/benchmarking/actions-runner/_work/benchmarking/benchmarking/cpython/Lib/asyncio/runners.py", line 118, in run
2023-05-07T01:58:11.2530148Z     return self._loop.run_until_complete(task)
2023-05-07T01:58:11.2530507Z            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2023-05-07T01:58:11.2531328Z   File "/home/benchmarking/actions-runner/_work/benchmarking/benchmarking/cpython/Lib/asyncio/base_events.py", line 664, in run_until_complete
2023-05-07T01:58:11.2531875Z     return future.result()
2023-05-07T01:58:11.2532172Z            ^^^^^^^^^^^^^^^
2023-05-07T01:58:11.2533318Z   File "/home/benchmarking/actions-runner/_work/benchmarking/benchmarking/venv/cpython3.12-42c7efcc310b-compat-07e19f9c3993/lib/python3.12/site-packages/pyperf/_runner.py", line 580, in main
2023-05-07T01:58:11.2533980Z     await local_func()
2023-05-07T01:58:11.2534965Z   File "/home/benchmarking/actions-runner/_work/benchmarking/benchmarking/venv/lib/python3.12/site-packages/pyperformance/data-files/benchmarks/bm_asyncio_tcp/run_benchmark.py", line 33, in main
2023-05-07T01:58:11.2535666Z     server_context.load_cert_chain(SSL_CERT, SSL_KEY)
2023-05-07T01:58:11.2536113Z FileNotFoundError: [Errno 2] No such file or directory

@kumaraditya303 kumaraditya303 merged commit 2e053ce into python:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdboom @kumaraditya303