Properly handle -dev suffix on tags and ranges. by zooba · Pull Request #436 · python/pymanager

zooba · 2026-10-30T10:57:20Z

Fixes #428

Copilot

🟡 Changes recommended

Installed listings can still select a stable release for 3-dev, while execution can choose an x64 prerelease despite an available preferred ARM64 prerelease.

2 open issues

What changed in this PR

This PR addresses #428 by making -dev tags and ranges signal prerelease preference during runtime selection.

Changes:

Add prerelease-preference detection for tags and ranges, excluding negated constraints.
Apply that preference to installation lookup, execution, and online single-result listings.
Add tests for suffix casing, platform suffixes, and range operators.

File	Description
tests/test_tagutils.py	Tests prerelease preferences for tags and ranges.
src/manage/tagutils.py	Adds suffix checking and prerelease-preference properties.
src/manage/list_command.py	Honors prerelease preference in online `--one` listings.
src/manage/installs.py	Prefers matching installed prereleases for execution.
src/manage/indexutils.py	Infers installation prerelease preference from the requested tag or range.

_{Review effort: Balanced}

Copilot

🟡 Changes recommended

Unresolved runtime-selection regressions can produce missing or multiple results, violate managed-only and version filters, and raise uncaught exceptions.

7 open issues

2 resolved since last review

_{Review effort: Balanced}

Copilot

🔵 Needs a closer look

Active selection regressions allow --online --one to return multiple runtimes and cause --one to omit installed defaults or valid prerelease matches.

3 open issues

2 previously missed issues

In code that hasn't changed since last review

Preserve a runtime when --one is used without filters

src/manage/list_command.py:388

Without any filters, tags is empty, so the new loop never adds a candidate and line 404 replaces the installed runtimes with an empty list. Consequently, py list --one -f=exe produces no executable even when a default runtime is installed. Preserve the marked default (or first available runtime) when there are no filters, and use the per-tag selection only for explicit filters.

Use listing aliases when selecting filtered prerelease runtimes

src/manage/list_command.py:400

This second filtering pass requires a matching run-for alias, although listing uses install-for aliases. Prerelease records generated by scripts/generate-nuget-index.py include 3-dev-64 in install-for but not in run-for, so py list --one 3-dev discards these valid listing matches and can print nothing. Rank candidates using the listing match rules rather than requiring a runnable alias for the filter.

4 resolved since last review

_{Review effort: Balanced}

Copilot

🟡 Changes recommended

An unconditional debug print corrupts JSON output, while unresolved regressions break single-result selection, tag matching, and version equality/hash consistency.

7 open issues

2 resolved since last review

_{Review effort: Balanced}

Copilot

🟡 Changes recommended

Active issues cause inequality constraints to reject valid runtimes with omitted micro versions and allow py list --online --one to return multiple results when platform selection falls back.

1 open issue

Allow shorter numeric tags in inequality comparisons · New

7 resolved since last review

_{Review effort: Balanced}

Copilot

🟡 Changes recommended

Non--dev range matching can select out-of-range runtimes, online --one fallbacks can return multiple results, and the new version assertion always fails.

2 open issues

1 resolved since last review

Allow shorter numeric tags in inequality comparisons

_{Review effort: Balanced}

-        else:
-            if any(f.satisfied_by(t) for t in install_tags):
-                return True
+        if any(f.satisfied_by(t) for t in install_tags):


@@ -20,10 +29,11 @@ def test_version(ver_str):
 def test_long_version(assert_log):
    v = "3.1.2.3.4.5.6.7.8.9"
    v2 = "3.1.2.3.4.5.6.7"


…and we rely on longer tags

zooba added 3 commits October 30, 2026 10:56

Properly handle -dev suffix on tags and ranges.

f3235c6

Fixes python#428

Always ensure tag is a tag

474a015

Tag is optional

d14f03a

zooba requested a balanced review from Copilot November 3, 2026 21:29

Copilot started reviewing on behalf of zooba November 3, 2026 21:30

View session

Copilot AI reviewed Nov 3, 2026

View reviewed changes

Comment thread src/manage/installs.py Resolved

Comment thread src/manage/list_command.py Resolved

zooba added 2 commits November 3, 2026 23:00

Improved handling of tag selection - still WIP

ee72b88

Fix -dev handling for py list

725b84f

zooba requested a balanced review from Copilot November 11, 2026 23:30

Copilot started reviewing on behalf of zooba November 11, 2026 23:31

View session

Copilot AI reviewed Nov 11, 2026

View reviewed changes

Simplify check and fix order

be8d639

zooba requested a balanced review from Copilot November 12, 2026 15:44

Copilot started reviewing on behalf of zooba November 12, 2026 15:44

View session

Copilot AI reviewed Nov 12, 2026

View reviewed changes

Tweaked version parsing and improved comparisons

530590f

zooba requested a balanced review from Copilot November 12, 2026 23:14

Copilot started reviewing on behalf of zooba November 12, 2026 23:15

View session

Copilot AI reviewed Nov 12, 2026

View reviewed changes

Comment thread src/manage/tagutils.py Resolved

Comment thread src/manage/list_command.py Resolved

Comment thread src/manage/list_command.py Resolved

Comment thread src/manage/tagutils.py Resolved

Comment thread src/manage/verutils.py Resolved

Comment thread src/manage/verutils.py Resolved

zooba added 4 commits November 13, 2026 00:36

[WIP] Few fixes, reverting back to tags definitely not being versions

26539b6

Remove redundant tests

e71ede1

Vastly more improvements to the logic, including docs

c4ba099

More cleanup

8875fd1

zooba requested a balanced review from Copilot November 13, 2026 13:00

Copilot started reviewing on behalf of zooba November 13, 2026 13:01

View session

Copilot AI reviewed Nov 13, 2026

View reviewed changes

Comment thread src/manage/tagutils.py Resolved

More regression tests and remove index reordering

9eb14f5

zooba mentioned this pull request Nov 13, 2026

Improve PyManager documentation around tag matching python/cpython#161940

Open

Refactoring

93b3106

zooba requested a balanced review from Copilot November 13, 2026 15:27

Copilot started reviewing on behalf of zooba November 13, 2026 15:27

View session

Copilot AI reviewed Nov 13, 2026

View reviewed changes

zooba added 2 commits November 13, 2026 15:54

Treat short tags as ambiguous versions so they fail more constraints …

c5c757f

…and we rely on longer tags

Fix constraint parsing and add new tests from docs

bdfe136

Conversation

zooba commented Oct 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants