Fix typos in PEPs using codespell#3909
Merged
hugovk merged 9 commits intopython:mainfrom Aug 20, 2024
Merged
Conversation
corneliusroemer
requested review from
CAM-Gerlach,
JelleZijlstra,
brandtbucher,
brettcannon,
encukou,
jackjansen,
kushaldas,
markshannon,
savannahostrowski,
vstinner and
zooba
as code owners
|
All commit authors signed the Contributor License Agreement. |
corneliusroemer
requested review from
a team,
ambv,
dstufft,
hugovk,
malemburg and
ncoghlan
as code owners
corneliusroemer
changed the title
Rosuav
reviewed
Aug 18, 2024
Contributor
|
IMO these are all small changes - a bunch of simple and non-controversial spelling corrections, plus associated infrastructure - so I'm fine with it all being one PR. There's one false positive, but otherwise LGTM. |
corneliusroemer
commented
Aug 18, 2024
savannahostrowski
approved these changes
Aug 18, 2024
Member
savannahostrowski
left a comment
savannahostrowski
left a comment
There was a problem hiding this comment.
Thanks, these LGTM!
Rosuav
approved these changes
Aug 18, 2024
hugovk
removed request for
CAM-Gerlach,
JelleZijlstra,
brandtbucher,
encukou,
hugovk,
jackjansen,
malemburg,
markshannon,
ncoghlan and
zooba
hugovk
changed the title
hugovk
requested changes
Aug 18, 2024
Closed
JelleZijlstra
approved these changes
Aug 18, 2024
AA-Turner
approved these changes
Aug 19, 2024
Contributor
Author
|
Note: In addition to the changes requested/suggested by @AA-Turner and @hugovk in review, I've added the extra ignore directories:
|
It seems codespell was last run on peps up to around 481 since there's only one typo up to pep 100 and many thereafter.
… mode (without names)
corneliusroemer
force-pushed
the
codespell-typos
branch
from
aa6e867 to
67bca51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems codespell was last run on peps up to around 481, since there's only one typo up to pep 100 and many thereafter.
Is this ok or do I need to make a separate PR for each PEP? That would be 18 which would be a bit annoying but I can do it if there should be no exception to the rule.
I ran codespell from main (commit codespell-project/codespell@f8e1b5f) with the following invokation:
📚 Documentation preview 📚: https://pep-previews--3909.org.readthedocs.build/