PEP 7: Clarify that compiler extensions are prohibited in general, not just GCC#2263
Merged
Merged
Conversation
CAM-Gerlach
changed the title
JelleZijlstra
approved these changes
Jan 24, 2022
AA-Turner
approved these changes
Jan 24, 2022
…hon#758 Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
CAM-Gerlach
force-pushed
the
pep-7-clarify-compiler-exts
branch
from
January 24, 2022 23:25
b06cb4f to
cc6b8ee
Compare
|
Thank you !
…On Mon, 2022-01-24 at 14:46 -0800, CAM Gerlach wrote:
Tweaks the wording of PEP 7 slightly, per @encukou 's suggestion on
@erikjanss 's issue, to clarify that compiler extensions are
prohibited in general, mentioning GCC and MSVC as specific offenders
and retaining the existing GCC example, rather than just only GCC
extensions specifically.
Fixes #758
You can view, comment on, or merge this pull request online at:
#2263
Commit Summary
4c30b75 PEP 7: Prohibit compiler extensions in general, not just
GCC, per #758
File Changes (1 file)
M
pep-0007.txt
(4)
Patch Links:
https://github.com/python/peps/pull/2263.patch
https://github.com/python/peps/pull/2263.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: <
***@***.***>
[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#2263",
"url": "#2263",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
brettcannon
approved these changes
Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tweaks the wording of PEP 7 slightly, per @encukou 's suggestion on @erikjanss 's issue, to clarify that compiler extensions are prohibited in general, mentioning GCC and MSVC as specific offenders and retaining the existing GCC example, rather than just only GCC extensions specifically.
Fixes #758