PEP 544: Couple final edits #1084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
approved these changes
May 23, 2019
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Are callback protocols well known to the other type checker teams, or do we have to remind them of this addition to the PEP?
Co-Authored-By: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Member
Author
I am not sure, but it is a relatively old feature in mypy (since August IIRC) and it appeared many times in discussions on Gitter. Plus IMO it is not that special from the point of view of "theory", it is just important from practical point of view. |
Member
Author
|
On the other hand we can post a brief summary of all recent changes to the PEP. What do you think? |
Member
|
TBH I just want to accept it. But if you can post a summary that would be
great.
On Fri, May 24, 2019 at 06:06 Ivan Levkivskyi ***@***.***> wrote:
On the other hand we can post a brief summary of *all* recent changes to
the PEP. What do you think?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1084?email_source=notifications&email_token=AAWCWMUOZDFLHRCCYFPHS6LPW7R6DA5CNFSM4HPKTSFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWFIXPY#issuecomment-495619007>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWCWMWGIG5YUPF6UJVNLHDPW7R6DANCNFSM4HPKTSFA>
.
--
--Guido (mobile)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes couple edits inspired by recent discussions:
cc @ambv @JukkaL @gvanrossum