Adds get_function_signature_hook#9102
Merged
msullivan merged 4 commits intopython:masterfrom Oct 18, 2020
sobolevn:issue-9101
Merged
Adds get_function_signature_hook#9102msullivan merged 4 commits intopython:masterfrom sobolevn:issue-9101
msullivan merged 4 commits intopython:masterfrom
sobolevn:issue-9101
Conversation
msullivan
reviewed
Oct 18, 2020
mypy/checkexpr.py
Outdated
|
|
||
| return None | ||
|
|
||
| def apply_function_signature_hook( |
Collaborator
There was a problem hiding this comment.
Would it be possible to merge this with apply_method_signature_hook? Maybe with a joint helper that takes formal args, callee, context, and the checker, and then pass different versions of that to the joint helper?
Collaborator
There was a problem hiding this comment.
Actually I just did this myself
msullivan
reviewed
Oct 18, 2020
Collaborator
msullivan
left a comment
msullivan
left a comment
There was a problem hiding this comment.
This looks good, one request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
get_function_signature_hookthat behaves the similar way asget_method_signature_hook.Closes #9101