Update common issues to include __init__ without arguments#8303
Merged
ilevkivskyi merged 3 commits intopython:masterfrom Jan 25, 2020
Merged
Update common issues to include __init__ without arguments#8303ilevkivskyi merged 3 commits intopython:masterfrom
ilevkivskyi merged 3 commits intopython:masterfrom
Conversation
- common issues and solutions -> No errors reported for obviously wrong code
Contributor
Author
|
This should close #8289 as well. |
ilevkivskyi
approved these changes
Jan 25, 2020
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Great, thanks! (I just made one minor formatting tweak.)
sthagen
added a commit
to sthagen/python-mypy
that referenced
this pull request
Jan 26, 2020
Update common issues to include __init__ without arguments (python#8303)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the implication of #5677 where the return type of
__init__is inferred given that at least one argument is typed.However, if no argument is present in
__init__,-> Nonebecomes compulsory if we are to enable type-checking on that method without using--check-untyped-defsflag. I believe it is worth mentioning in the section of "No errors reported for obviously wrong code".