Skip to content

Fix dataclass plugin interaction with member expressions#6739

Merged
ilevkivskyi merged 2 commits intopython:masterfrom
ilevkivskyi:fix-dataclasses-field
Apr 30, 2019
Merged

Fix dataclass plugin interaction with member expressions#6739
ilevkivskyi merged 2 commits intopython:masterfrom
ilevkivskyi:fix-dataclasses-field

Conversation

@ilevkivskyi
Copy link
Copy Markdown
Member

Fixes #6516

It also fixes minor corner case that affects tests cases proposed in the issue.

Copy link
Copy Markdown
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit.

@ilevkivskyi ilevkivskyi merged commit e8a72a0 into python:master Apr 30, 2019
@ilevkivskyi ilevkivskyi deleted the fix-dataclasses-field branch April 30, 2019 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect "Attributes without a default cannot follow attributes with one" in dataclasses

2 participants