Create new, hidden window when starting daemon on Windows#5994
Merged
Conversation
Michael0x2a
approved these changes
Dec 3, 2018
Michael0x2a
left a comment
Michael0x2a
left a comment
Collaborator
There was a problem hiding this comment.
I tried running this, and can confirm it fixes the problem -- thanks for the super-quick turnaround!
Member
Author
|
You're welcome! It was definitely something I wanted to look into, but it never really bothered me that much. But now that I fixed it I could never go back :P |
Closed
JukkaL
pushed a commit
that referenced
this pull request
Dec 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5991
Basically grandchildren could allocate new consoles, which we were somewhere. This changes things so we create a new console (which seems to detach us from the parent process...) but we create it hidden, so that it is invisible. For more, and the source for the solution, you might want to read python/cpython#4150 (comment).