Conversation
This allows the 'unreachable' flag to not need to be accessed via GetAttr, and for dict operations to be done via dict primitives. Amazingly, this gives a ~200ms speedup on self check (like 6%!).
gvanrossum
reviewed
Oct 10, 2018
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Nice -- I like that this (in a sense) removes an awkward subclass and speed things up.
JukkaL
approved these changes
Oct 10, 2018
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Wow! I wonder if we have other similar non-obvious big inefficiencies lurking inside the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the 'unreachable' flag to not need to be accessed via
GetAttr, and for dict operations to be done via dict primitives
(though I'm going to put up a mypyc change soon that makes that second
part always true.)
Amazingly, this gives a ~200ms speedup on self check (like 6%!).