Support __new__ in fine grained mode#4763
Merged
ilevkivskyi merged 6 commits intopython:masterfrom Mar 21, 2018
Merged
Conversation
JukkaL
approved these changes
Mar 21, 2018
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Looks good, just a few comments about test cases.
test-data/unit/fine-grained.test
Outdated
| == | ||
| a.py:3: error: Argument 1 to "C" has incompatible type "int"; expected "str" | ||
|
|
||
| [case testDunderNewUpdatedFunc] |
Collaborator
There was a problem hiding this comment.
Not sure if we need both this and the above test case (testMetaclassAttributesDirect) since they are pretty similar.
| == | ||
| a.py:3: error: Argument 1 to "C" has incompatible type "int"; expected "str" | ||
|
|
||
| [case testDunderNewUpdatedMethod] |
Collaborator
There was a problem hiding this comment.
Again this test case seems redundant.
| def __new__(cls, x: str) -> C: | ||
| pass | ||
| [out] | ||
| == |
Collaborator
There was a problem hiding this comment.
Ideas for additional test cases:
- Add
__new__when originally there was nothing. - Replace
__init__with__new__.
Member
Author
|
@JukkaL Thanks for review! I left only one of three boring tests, and added the two other tests you proposed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a straightforward PR that essentially adds same dependencies on
__new__as we have on__init__for a class as a callable.Just in case I add few dedicated tests.