Fix a handful of fine-grained incremental bugs#4691
Merged
Conversation
JukkaL
approved these changes
Mar 7, 2018
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Looks good, just a few comments.
test-data/unit/fine-grained.test
Outdated
| [case testImplicitTuple1] | ||
| import a | ||
| [file a.py] | ||
| # Bogus annotation in nested function masked because |
Collaborator
There was a problem hiding this comment.
Something missing in the comment? "... function masked because [what]"
mypy/server/update.py
Outdated
| changed_modules = dedupe_modules(remaining + changed_modules) | ||
| t1 = time.time() | ||
|
|
||
| self.manager.log_fine_grained( |
Collaborator
There was a problem hiding this comment.
This seems unrelated to the rest of thePR?
Collaborator
Author
There was a problem hiding this comment.
Oh, indeed. I added it to track progress while running mypy-daemon on a big changed repo. I can split it out.
This reverts commit f4b8839.
yedpodtrzitko
pushed a commit
to kiwicom/mypy
that referenced
this pull request
Mar 15, 2018
* Fix refresh of implicit tuple types * Fix refresh of imports in if MYPY else blocks * Fix astmerge of CastExpr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes all of the bugs found while running fine-grained incremental on the S repo with every file changed trivially.