Better error message for incompatible default argument (take 2)#3783
Merged
Conversation
Add tests for tuple parameter
Contributor
Author
gvanrossum
requested changes
Jul 31, 2017
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
Please just fix the nit (remove no'), don't do anything else.
| name = arg.variable.name() | ||
| msg = 'Incompatible default for ' | ||
| if name.startswith('__tuple_arg_'): | ||
| msg += "tuple argument no' {}".format(name[12:]) |
Member
There was a problem hiding this comment.
Few people will understand argument no' 1 -- just get rid of the no' and make it argument 1 please.
gvanrossum
approved these changes
Jul 31, 2017
Member
|
Thanks! Next time it would be nice to have an issue before you start coding. :-) |
Contributor
Author
|
Will do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopen #3773