Support from ... import ... with module level __getattr__#3779
Merged
ilevkivskyi merged 3 commits intopython:masterfrom Jul 30, 2017
Merged
Support from ... import ... with module level __getattr__#3779ilevkivskyi merged 3 commits intopython:masterfrom
ilevkivskyi merged 3 commits intopython:masterfrom
Conversation
PEP 484 specifies one can def __getattr__(name): ... to specify that unresolved names should be Any (or the return type of the getattr method). This change adds support for access to these attributes via the from module import name pattern. The module.name pattern is already supported.
ilevkivskyi
approved these changes
Jul 30, 2017
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Thanks! There is only one comment. Most empty lines in the tests could be removed (I am OK with them, but Guido really does not like them). Maybe only keep the empty lines before [file ...] and [case ...]?
Member
Author
|
Ah, okay. I tried to keep it in the style, but perhaps I added too many. I'll make that change. |
Member
Author
|
Okay, I kept spaces between |
Member
|
I will merge when tests pass. |
Member
Except that they failed :-) Could you please fix the line numbers in the test output? |
Member
Author
|
Sorry about the line number problems. Should be good now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP 484 specifies one can
def __getattr__(name): ...to specify thatunresolved names should be Any (or the return type of the
__getattr__method). This change adds support for access to these attributes via the
from module import namepattern. Themodule.namepattern is alreadysupported.