Make mypy --no-implicit-optional clean for strict Optional-checked files#3699
Merged
gvanrossum merged 4 commits intomasterfrom Jul 12, 2017
Merged
Make mypy --no-implicit-optional clean for strict Optional-checked files#3699gvanrossum merged 4 commits intomasterfrom
gvanrossum merged 4 commits intomasterfrom
Conversation
gvanrossum
changed the title
Member
|
I tried to look into the 3.5.1-specific failure. It's related to the premature evaluation of forward declarations in typing.py. IIRC their processing changed quite a bit between 3.5.1 and 3.5.2. I noticed you replaced several occurrences of To test this locally you'll have to install Python 3.5.1 from python.org. |
JelleZijlstra
changed the title
gvanrossum
approved these changes
Jul 12, 2017
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
LG, needs merge and then hopefully the Appveyor tests will run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.