Skip to content

fix: refactor sem analysis of the await-not-async on generators and list comprehension #18152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josetapadas wants to merge 12 commits into
base: master
Choose a base branch
from
Open

fix: refactor sem analysis of the await-not-async on generators and list comprehension #18152

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d3b2d9d
fix: refactor sem analysis of the await-not-async on generators and l…
josetapadas Nov 13, 2024
ed2937a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 13, 2024
c97bce7
chore: added unit test
josetapadas Nov 13, 2024
ada4720
chore: refactor to remove function for simple check
josetapadas Nov 13, 2024
43fc65a
fix: fixed the await outside coroutine within list comprehensions error
josetapadas Nov 13, 2024
e3004a1
chore: error type is not syntax but await-not-async
josetapadas Nov 13, 2024
e7ef1f6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 13, 2024
0c82fb9
fix: added await-outside-coroutine checks also to list and dict compr…
josetapadas Nov 14, 2024
8e8298e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 14, 2024
0fee8d6
chore: remove artefact from update data
josetapadas Nov 18, 2024
95c5730
chore: fail consistently for the new case also on the set comprehension
josetapadas Nov 18, 2024
48148ac
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks 
for more information, see https://pre-commit.ci
  • Loading branch information
@pre-commit-ci
pre-commit-ci[bot] committed Nov 13, 2024
commit e7ef1f686db61b176705e69ceffcf34101f59d1d
5 changes: 4 additions & 1 deletion mypy/semanal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6186,7 +6186,10 @@ def visit_await_expr(self, expr: AwaitExpr) -> None:
# This is not a blocker, because some enviroments (like ipython)
# support top level awaits.
self.fail('"await" outside function', expr, serious=True, code=codes.TOP_LEVEL_AWAIT)
elif not self.function_stack[-1].is_coroutine and self.scope_stack[-1] != SCOPE_COMPREHENSION:
elif (
not self.function_stack[-1].is_coroutine
and self.scope_stack[-1] != SCOPE_COMPREHENSION
):
self.fail(
message_registry.AWAIT_WITH_OUTSIDE_COROUTINE,
expr,
Expand Down
Loading