Fix Generators typeshed test #10255
Merged
Fix Generators typeshed test #10255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typshed mistakenly set itertools.count as a function while it is actually a class. Meaning that it returns a class instance and then this clashes with the filter result.
Collaborator
|
Thanks for this! Yeah, in general the mypy-typeshed dependency can cause some friction. In this case, I'm not sure that we should actually make this change in typeshed... Opened python/typeshed#5145 to discuss :-) |
Member
|
Even if we don't make the change in typeshed, it seems harmless to make this change so that we make CI for the two projects a bit less interdependent, so I'm going to merge it. |
Collaborator
|
This has caused |
Member
|
Sorry for missing that, fixed it in #10315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
typshed mistakenly set itertools.count as a function while it is actually a class. Meaning that it returns a class instance and then this clashes with the filter assignment in the test.
I want to fix the typeshed side but the mypy test on THEIR repo fails because of this.
Test Plan
Mypy behaves the same but tests should be more in line with itertools actual typing.