fix: fixed the await outside coroutine within list comprehensions error

josetapadas · josetapadas · commit 43fc65af4a09 · 2024-11-13T11:17:47.000Z
diff --git a/mypy/message_registry.py b/mypy/message_registry.py
@@ -80,6 +80,8 @@ def with_additional_msg(self, info: str) -> ErrorMessage:
 ASYNC_FOR_OUTSIDE_COROUTINE: Final = '"async for" outside async function'
 ASYNC_WITH_OUTSIDE_COROUTINE: Final = '"async with" outside async function'
 
+AWAIT_WITH_OUTSIDE_COROUTINE: Final = '"await" outside coroutine ("async def")'
+
 INCOMPATIBLE_TYPES_IN_YIELD: Final = ErrorMessage('Incompatible types in "yield"')
 INCOMPATIBLE_TYPES_IN_YIELD_FROM: Final = ErrorMessage('Incompatible types in "yield from"')
 INCOMPATIBLE_TYPES_IN_STR_INTERPOLATION: Final = "Incompatible types in string interpolation"
diff --git a/mypy/semanal.py b/mypy/semanal.py
@@ -6075,14 +6075,22 @@ def visit_type_application(self, expr: TypeApplication) -> None:
                 expr.types[i] = analyzed
 
     def visit_list_comprehension(self, expr: ListComprehension) -> None:
-        if any(expr.generator.is_async) or has_await_expression(expr):
+        if any(expr.generator.is_async):
             if not self.is_func_scope() or not self.function_stack[-1].is_coroutine:
                 self.fail(
                     message_registry.ASYNC_FOR_OUTSIDE_COROUTINE,
                     expr,
                     code=codes.SYNTAX,
                     serious=True,
                 )
+        elif has_await_expression(expr):
+            if not self.is_func_scope() or not self.function_stack[-1].is_coroutine:
+                self.fail(
+                    message_registry.AWAIT_WITH_OUTSIDE_COROUTINE,
+                    expr,
+                    code=codes.SYNTAX,
+                    serious=True,
+                )
 
         expr.generator.accept(self)
 
@@ -6180,7 +6188,7 @@ def visit_await_expr(self, expr: AwaitExpr) -> None:
             self.fail('"await" outside function', expr, serious=True, code=codes.TOP_LEVEL_AWAIT)
         elif not self.function_stack[-1].is_coroutine and self.scope_stack[-1] != SCOPE_COMPREHENSION:
             self.fail(
-                '"await" outside coroutine ("async def")',
+                message_registry.AWAIT_WITH_OUTSIDE_COROUTINE,
                 expr,
                 serious=True,
                 code=codes.AWAIT_NOT_ASYNC,
diff --git a/test-data/unit/check-async-await.test b/test-data/unit/check-async-await.test
@@ -1013,15 +1013,16 @@ async def foo(x: int) -> int: ...
 
 # These are allowed in some cases:
 top_level = await foo(1)  # E: "await" outside function  [top-level-await]
-crasher = [await foo(x) for x in [1, 2, 3]]  # E: "async for" outside async function  [syntax] \
+crasher = [await foo(x) for x in [1, 2, 3]]  # E: "await" outside coroutine ("async def")  [syntax] \
                                              # E: "await" outside function  [top-level-await]
 
 def bad() -> None:
     # These are always critical / syntax issues:
-    y = [await foo(x) for x in [1, 2, 3]]  # E: "async for" outside async function  [syntax]
+    y = [await foo(x) for x in [1, 2, 3]]  # E: "await" outside coroutine ("async def")  [syntax]
 async def good() -> None:
     y = [await foo(x) for x in [1, 2, 3]]  # OK
 
+
 [builtins fixtures/async_await.pyi]
 [typing fixtures/typing-async.pyi]
 
