Fix path handling and masked errors on Windows for installed-files.txt #454
+16
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jaraco
commented
Apr 22, 2023
jaraco
commented
- Resolve the located directory and remove suppression of Exceptions. Ref importlib/test_metadata_api fails on Windows buildbots cpython#103661.
- Wrap 'subdir/line' in PosixPath to ensure the output uses posix path separators. Ref importlib/test_metadata_api fails on Windows buildbots cpython#103661.
Member
Author
|
Note that after the first commit, the error uncovered by Python buildbots in python/cpython#103661 is revealed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.