Skip to content

Conversation

@paulmon
Copy link
Contributor

@paulmon paulmon commented Feb 26, 2019

test_SEH still fails. I'm trying to track down unwind semantics for armasm.exe if possible.

@paulmon
Copy link
Contributor Author

paulmon commented Mar 30, 2019

@zooba @zware
These ARM changes include unwind semantics now, and have also been submitted to libffi.
libffi/libffi#477

safeseh=
shift 1
;;
-marm)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where -marm is defined.

@zooba
Copy link
Member

zooba commented Apr 15, 2019

Okay, I didn't notice this patch, sorry.

We're diverging significantly from libffi now, and I'm not so keen on that just yet. How can we help move along the patch on their side?

@paulmon
Copy link
Contributor Author

paulmon commented Apr 16, 2019

I pinged the PR discussion and sent email to the libffi-discussion alias.
libffi/libffi#477
https://sourceware.org/ml/libffi-discuss/2019/msg00003.html

@zooba
Copy link
Member

zooba commented Apr 17, 2019

I'm going to merge this, but @paulmon if it doesn't make it into libffi then we'll need the patch again next time we take an update from them.

@zooba zooba merged commit 82244f9 into python:libffi Apr 17, 2019
@paulmon
Copy link
Contributor Author

paulmon commented Apr 17, 2019

Understood. Thanks!

@paulmon
Copy link
Contributor Author

paulmon commented Apr 27, 2019

These changes were merged into libffi/master on 4/25
libffi/libffi#477 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants