Skip to content

[3.7] bpo-34536: raise error for invalid _missing_ results (GH-9147)#9978

Merged
ethanfurman merged 1 commit into
python:3.7from
vstinner:3.7
Oct 19, 2018
Merged

[3.7] bpo-34536: raise error for invalid _missing_ results (GH-9147)#9978
ethanfurman merged 1 commit into
python:3.7from
vstinner:3.7

Conversation

@vstinner

@vstinner vstinner commented Oct 19, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member
  • raise exception if missing returns None or invalid type

(cherry picked from commit 019f0a0)

https://bugs.python.org/issue34536

@ethanfurman @vstinner
bpo-34536: raise error for invalid _missing_ results (GH-9147)
078a6a6 
* raise exception if _missing_ returns None or invalid type

(cherry picked from commit 019f0a0)
@vstinner
vstinner requested a review from ethanfurman October 19, 2018 23:03
@vstinner vstinner mentioned this pull request Oct 19, 2018
Closed
@vstinner

vstinner commented Oct 19, 2018

Copy link
Copy Markdown
Member Author

Note: the cherry-picked commit added "import sys" but the sys module is unused in test_enum of Python 3.7, so I removed it. See also my PR #9979.

@ethanfurman ethanfurman self-assigned this Oct 19, 2018
@ethanfurman
ethanfurman merged commit 0f2fc8b into python:3.7 Oct 19, 2018
@ethanfurman

ethanfurman commented Oct 19, 2018

Copy link
Copy Markdown
Member

Thanks, Victor!

@vstinner
vstinner deleted the 3.7 branch November 30, 2018 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes

Assignees

@ethanfurman ethanfurman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @ethanfurman @the-knights-who-say-ni @bedevere-bot