Skip to content

[3.11] gh-99357: Close the event loop when it is no longer used in test_uncancel_structured_blocks (GH-99414) #99424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gvanrossum merged 2 commits into from
Nov 14, 2022
Merged

[3.11] gh-99357: Close the event loop when it is no longer used in test_uncancel_structured_blocks (GH-99414) #99424

gvanrossum merged 2 commits into from
Nov 14, 2022

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 13, 2022 •
edited by bedevere-bot
Loading

@xiaochen7 @miss-islington
pythongh-99357: Close the event loop when it is no longer used in tes…
29f11df 
…t_uncancel_structured_blocks (pythonGH-99414)

(cherry picked from commit 99972dc)

Co-authored-by: Xiao Chen <chenxiao_7@163.com>
@bedevere-bot bedevere-bot mentioned this pull request Nov 13, 2022
Closed
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Nov 13, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 13, 2022
Merged
@gvanrossum
Copy link
Member

gvanrossum commented Nov 13, 2022

I'm seeing if the Windows test failure in test_asyncgen was a fluke or repeats itself.

@gvanrossum
Copy link
Member

gvanrossum commented Nov 13, 2022 •
edited
Loading

Unfortunately it keeps failing on Windows, AFAICT in test_asyncio. Maybe closing the loop triggers something funky? Maybe we need to wait for certain events to occur? I guess ProactorEventLoop behaves sufficiently differently that we cannot rule this out. @kumaraditya303

@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Nov 14, 2022

Unfortunately it keeps failing on Windows, AFAICT in test_asyncio. Maybe closing the loop triggers something funky? Maybe we need to wait for certain events to occur? I guess ProactorEventLoop behaves sufficiently differently that we cannot rule this out.

See #98219, it isn't related to this PR. I am unable to reproduce on Windows 11 so maybe this only happens on Windows Server versions or slow machines.

@gvanrossum
Copy link
Member

gvanrossum commented Nov 14, 2022

Sadly I cannot merge this with that test failing. I'll try running all the tests one more time, after that I'll invoke the RM.

@gvanrossum gvanrossum merged commit 90de4b7 into python:3.11 Nov 14, 2022
@miss-islington miss-islington deleted the backport-99972dc-3.11 branch November 14, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @gvanrossum @kumaraditya303 @bedevere-bot @xiaochen7