Skip to content

gh-98718: add sys.build_prefix#99273

Open
FFY00 wants to merge 2 commits into
python:mainfrom
FFY00:bpo-98718-build_prefix
Open

gh-98718: add sys.build_prefix#99273
FFY00 wants to merge 2 commits into
python:mainfrom
FFY00:bpo-98718-build_prefix

Conversation

@FFY00

@FFY00 FFY00 commented Nov 9, 2022

Copy link
Copy Markdown
Member

Alternative to #98719, but exporting sys.build_prefix.

Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
FFY00 force-pushed the bpo-98718-build_prefix branch from 7c3e199 to 3bc6847 Compare November 9, 2022 03:21
Signed-off-by: Filipe Laíns <lains@riseup.net>
@zooba

zooba commented Nov 9, 2022

Copy link
Copy Markdown
Member

I wonder if, rather than plumbing this the whole way through, we can simply assign it to the sys module in getpath.py? There's no real value in making this configurable, and honestly I'd rather remove or fix anything that requires this.

@FFY00

FFY00 commented Nov 10, 2022

Copy link
Copy Markdown
Member Author

Yes, I think that makes sense.

By configurable you are referring to setting it when embedding, right? I was under the impression we needed further changes to make that actually work.

@zooba

zooba commented Nov 10, 2022

Copy link
Copy Markdown
Member

By configurable you are referring to setting it when embedding, right? I was under the impression we needed further changes to make that actually work.

Just needs to be put into PyConfig and set up to be cleared/copied (as you've done). But on second thoughts, you're not going to be able to set the sys module directly here anyway, so probably it needs to go back into PyConfig at this stage.

If we're to go ahead with this, I'd make the PyConfig field private (leading underscore). Or if we can come up with a better way to set up the sys module from within getpath.py, I'd like that more.

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants