Skip to content

bpo-31522: mailbox: pass from_ parameter to get_bytes#9857

Merged
bitdancer merged 2 commits into
python:masterfrom
csabella:bpo31522
Oct 19, 2018
Merged

bpo-31522: mailbox: pass from_ parameter to get_bytes#9857
bitdancer merged 2 commits into
python:masterfrom
csabella:bpo31522

Conversation

@csabella

@csabella csabella commented Oct 13, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Added tests that failed before the change and pass after the change.

https://bugs.python.org/issue31522

@csabella
csabella requested a review from a team as a code owner October 13, 2018 23:13
bitdancer
bitdancer requested changes Oct 16, 2018
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2018-10-13-18-16-20.bpo-31522.rWBb43.rst Outdated
@@ -0,0 +1 @@
In `mailbox._mboxMMDF.get_string`, pass *from_* parameter to ``get_bytes``.

@bitdancer bitdancer Oct 16, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This describes what was done, but the changelog should in general describe the externally visible affects of the change. In this case, I would write "The mailbox mbox get_string function from_ parameter can now successfully be set to a non-default value".

@csabella csabella Oct 16, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! :-)

@bedevere-bot

bedevere-bot commented Oct 16, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella

csabella commented Oct 16, 2018

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Oct 16, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@bitdancer: please review the changes made to this pull request.

@bitdancer
bitdancer merged commit d16f012 into python:master Oct 19, 2018
@bedevere-bot

bedevere-bot commented Oct 19, 2018

Copy link
Copy Markdown

@bitdancer: Please replace # with GH- in the commit message next time. Thanks!

@csabella
csabella deleted the bpo31522 branch October 19, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitdancer bitdancer bitdancer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@csabella @bedevere-bot @bitdancer @the-knights-who-say-ni