gh-98378: Add small format string example to strftime comments#98379
Merged
miss-islington merged 2 commits intopython:mainfrom Oct 18, 2022
Merged
gh-98378: Add small format string example to strftime comments#98379miss-islington merged 2 commits intopython:mainfrom
miss-islington merged 2 commits intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All commit authors signed the Contributor License Agreement. |
sobolevn
reviewed
Oct 18, 2022
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
In my opinion this does not quite solve the problem.
Why? It is still not clear what does it mean: you are either familiar with its API, or %H:%M won't help much.
But, I see that there are some similar PRs: https://github.com/python/cpython/pull/31761/files
It indicates that a problem is quite common.
I think you can start a discussion about it first: what and how it can be done in a useful, consistent, and simple manner.
rhettinger
approved these changes
Oct 18, 2022
A small example of what a full date and time would look like would help a lot of developers who may not realize that they should investigate `time.h`'s `strftime`, run `man strftime`, or click through a series of docs on the python docs before they get to the actual [definition here](https://docs.python.org/3/library/datetime.html#strftime-and-strptime-format-codes) which still doesn't have an obvious example of "what the heck format does this thing actually expect?".
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Contributor
|
Status check is done, and it's a success ✅. |
Contributor
|
Thanks @zvory for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 18, 2022
…ythonGH-98379) A small example of what a full date and time would look like would help a lot of developers who may not realize that they should investigate `time.h`'s `strftime`, run `man strftime`, or click through a series of docs on the python docs before they get to the actual [definition here](https://docs.python.org/3/library/datetime.htmlGH-strftime-and-strptime-format-codes) which still doesn't have an obvious copy-pastable example of "what the heck format does this thing actually expect?". Automerge-Triggered-By: GH:rhettinger (cherry picked from commit 6ccca69) Co-authored-by: Alex Zvorygin <grafetu@gmail.com>
Contributor
Author
|
@miss-islington Oh! What an easy process! I'm glad I was able to help, and I'm especially glad that it's this easy to help. |
Contributor
Author
|
oh that's a bot lmfao |
AlexWaygood
added a commit
that referenced
this pull request
Oct 22, 2022
…GH-98379) (#98395) gh-98378: Add small format string example to strftime comments (GH-98379) A small example of what a full date and time would look like would help a lot of developers who may not realize that they should investigate `time.h`'s `strftime`, run `man strftime`, or click through a series of docs on the python docs before they get to the actual [definition here](https://docs.python.org/3/library/datetime.htmlGH-strftime-and-strptime-format-codes) which still doesn't have an obvious copy-pastable example of "what the heck format does this thing actually expect?". Automerge-Triggered-By: GH:rhettinger (cherry picked from commit 6ccca69) Co-authored-by: Alex Zvorygin <grafetu@gmail.com> Co-authored-by: Alex Zvorygin <grafetu@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small example of what a full date and time would look like would help a lot of developers who may not realize that they should investigate
time.h'sstrftime, runman strftime, or click through a series of docs on the python docs before they get to the actual definition here which still doesn't have an obvious copy-pastable example of "what the heck format does this thing actually expect?".Automerge-Triggered-By: GH:rhettinger