bpo-34911: Added support for secure websocket cookies#9734
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
pizzapanther
changed the title
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again Tests added. Also signed the CLA how long does that take to get reviewed? |
|
Thanks for making the requested changes! @asvetlov: please review the changes made to this pull request. |
asvetlov
left a comment
asvetlov
left a comment
There was a problem hiding this comment.
Cool!
Next two steps are left.
- Update docs please. You've added a new argument to
DefaultCookiePolicyconstructor, it should be at least mentioned here: https://docs.python.org/3/library/http.cookiejar.html#http.cookiejar.DefaultCookiePolicy - Please add a NEWS fragment. Use blurb for it.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @asvetlov: please review the changes made to this pull request. |
asvetlov
changed the title
|
Please sign the CLA as the bot suggested in the very beginning of the conversation. |
|
Thanks! |
|
will this go into python 3.7 or 3.8? |
|
3.8 only: it is a new functionality |
4 participants
Added support for secure websocket cookies
bpo-34911: Added support for secure websocket cookies
https://bugs.python.org/issue34911