Skip to content

bpo-34900: Fix subTests to not crash when called from TestCase.debug() #9707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
berkerpeksag merged 2 commits into from
Oct 12, 2018
Merged

bpo-34900: Fix subTests to not crash when called from TestCase.debug() #9707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eddd087
Fix TestCase.debug() when used to call test methods with subtests
nicoddemus Oct 4, 2018
bb8a047
markup
berkerpeksag Oct 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/unittest/case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ def subTest(self, msg=_subtest_msg_sentinel, **params):
case as failed but resumes execution at the end of the enclosed
block, allowing further test code to be executed.
"""
if not self._outcome.result_supports_subtests:
if self._outcome is None or not self._outcome.result_supports_subtests:
yield
return
parent = self._subtest
Expand Down
14 changes: 14 additions & 0 deletions Lib/unittest/test/test_case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,20 @@ def test_c(self):
expected = ['a1', 'a2', 'b1']
self.assertEqual(events, expected)

def test_subtests_debug(self):
# Test debug() with a test that uses subTest() (bpo-34900)
events = []

class Foo(unittest.TestCase):
def test_a(self):
events.append('test case')
with self.subTest():
events.append('subtest 1')

Foo('test_a').debug()

self.assertEqual(events, ['test case', 'subtest 1'])

# "This class attribute gives the exception raised by the test() method.
# If a test framework needs to use a specialized exception, possibly to
# carry additional information, it must subclass this exception in
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2018-10-05-05-55-53.bpo-34900.8RNiFu.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fixed :meth:`unittest.TestCase.debug` when used to call test methods with

@nicoddemus nicoddemus Oct 5, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

subtests. Patch by Bruno Oliveira.