bpo-34711: Fix test_httpservers for AIX (trailingSlashOK)#9675
Closed
aixtools wants to merge 1 commit into
Closed
Conversation
nascheme
reviewed
Oct 3, 2018
| # Some OS accept trailingSlash as part of a filename | ||
| # https://bugs.python.org/issue34711#msg325532 mentions Windows sometimes accepts a trailingSlash | ||
| # so more work could be done | ||
| trailingSlashOK = platform.system() in ('AIX') |
Member
There was a problem hiding this comment.
Probably should use a literal set here. If you meant to use a tuple, you forgot the trailing comma. So, I suggest in {'AIX'} instead.
merwok
reviewed
Oct 3, 2018
| # Some OS accept trailingSlash as part of a filename | ||
| # https://bugs.python.org/issue34711#msg325532 mentions Windows sometimes accepts a trailingSlash | ||
| # so more work could be done | ||
| trailingSlashOK = platform.system() in ('AIX') |
Member
There was a problem hiding this comment.
This is a string, not a one-element tuple.
Equality test may be clearer (and simple to change if needed).
Contributor
Author
|
Closing. Per discussion in python-bugs (https://bugs.python.org/issue34711) shall address this issue in Lib/http/server.py |
Contributor
Author
|
On 03/10/2018 02:16, Neil Schemenauer wrote:
nascheme commented on this pull request.
> @@ -29,6 +30,10 @@
import unittest
from test import support
+# Some OS accept trailingSlash as part of a filename
+# https://bugs.python.org/issue34711#msg325532 mentions Windows sometimes accepts a trailingSlash
+# so more work could be done
+trailingSlashOK = platform.system() in ('AIX')
Probably should use a literal set here. If you meant to use a tuple, you forgot the trailing comma. So, I suggest `in {'AIX'}` instead.
Yes, that is what I intended - as a hint that other platforms could be
added. E.g., maybe Windows could also just be added (so it becomes
{'AIX', 'Windows'} because 'sometimes' Windows accepts a trailing slash.
What is guideline when there is a good reason to think it may be valid
for a platform, but cannot test it personally?
Note: this resolution path (fix in the test) has been dropped. Still
thanks for alerting me to the proper brackets!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34711