Skip to content

bpo-34849: Don't log wating for selector.select in asyncio loop iteration#9641

Merged
miss-islington merged 1 commit into
python:masterfrom
asvetlov:drop-annoying-output
Sep 30, 2018
Merged

bpo-34849: Don't log wating for selector.select in asyncio loop iteration#9641
miss-islington merged 1 commit into
python:masterfrom
asvetlov:drop-annoying-output

Conversation

@asvetlov

@asvetlov asvetlov commented Sep 30, 2018

Copy link
Copy Markdown
Contributor

The waiting is pretty normal for any asyncio program, logging its time just adds
a noise to logs without any useful information provided.

https://bugs.python.org/issue34849

waiting is pretty normal for any asyncio program, logging its time just adds
a noise to logs without any useful information provided.
@miss-islington

Copy link
Copy Markdown
Contributor

@asvetlov: Status check is done, and it's a success ✅ .

@miss-islington
miss-islington merged commit d5bd036 into python:master Sep 30, 2018
@asvetlov

Copy link
Copy Markdown
Contributor Author

@1st1 sorry, I thought @miss-islington requires at least one review approval, the review should be yours.
Unfortunately, bot merged PR just after tests passing.
Could you make a post-review? I'll revert the PR if it is not appropriate.

@1st1

1st1 commented Sep 30, 2018

Copy link
Copy Markdown
Member

This pr is fine.

@asvetlov
asvetlov deleted the drop-annoying-output branch October 1, 2018 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants