gh-95841: IDLE - Revise Windows local doc url#95845
Merged
terryjreedy merged 2 commits intopython:mainfrom Aug 11, 2022
Merged
Conversation
python#91242 replaced the Windows chm help file with a copy of the html docs. This PR replaces the IDLE code that fetches the Windows local help url passed to os.startfile.
terryjreedy
added
type-bug
zooba
reviewed
Aug 10, 2022
Member
zooba
left a comment
zooba
left a comment
There was a problem hiding this comment.
LGTM other than the Windows-only import, but maybe you know that's fine.
Member
Author
|
Thank you for reviewing. After fixes, manual re-tests on repository 3.12 and installed 3.11 still pass. A found hours ago, I found an August 2012 patch by Ned Deily updating the linux and macOS locations and changing the code a bit. I am saving that, with new updates, for 3.11.1. |
Contributor
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 11, 2022
pythonGH-91242 replaced the Windows chm help file with a copy of the html docs. This PR replaces the IDLE code that fetches the Windows local help url passed to os.startfile. Co-authored-by: Steve Dower (cherry picked from commit bdb2cf8) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-95905 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 11, 2022
pythonGH-91242 replaced the Windows chm help file with a copy of the html docs. This PR replaces the IDLE code that fetches the Windows local help url passed to os.startfile. Co-authored-by: Steve Dower (cherry picked from commit bdb2cf8) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-95906 is a backport of this pull request to the 3.10 branch. |
terryjreedy
pushed a commit
that referenced
this pull request
Aug 12, 2022
GH-91242 replaced the Windows chm help file with a copy of the html docs. This PR replaces the IDLE code that fetches the Windows local help url passed to os.startfile. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Steve Dower Approved by Steve Dower, #95845 (review), 2nd subblock. (cherry picked from commit bdb2cf8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#91242 replaced the Windows chm help file with a copy
of the html docs. This PR replaces the IDLE code that
fetches the Windows local help url passed to os.startfile.
It is based on Steve Dower's #91242 (comment).
Co-authored-by: Steve Dower